Add the go_package option to the protobuf files #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option will soon be required to generate the Go code for the protobuf files. Having valid protobuf files for Go would allow us to write report processors in this language. See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package > Source .proto files should contain a go_package option specifying the full Go import path for the file. If there is no go_package option, the compiler will try to guess at one. A future release of the compiler will make the go_package option a requirement. The Go package name of generated code will be the last path component of the go_package option. Test plan: Before: $ protoc vulnerability.proto --go_out=/tmp/ 2020/07/22 14:55:26 WARNING: Missing 'go_package' option in "vulnerability.proto", please specify it with the full Go package path as a future release of protoc-gen-go will require this be specified. See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package for more information. After: $ protoc vulnerability.proto --go_out=/tmp/ $ echo $? 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option will soon be required to generate the Go code for the protobuf files.
Having valid protobuf files for Go would allow us to write report processors in this language.
See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package
Test plan:
Before:
$ protoc vulnerability.proto --go_out=/tmp/
2020/07/22 14:55:26 WARNING: Missing 'go_package' option in "vulnerability.proto",
please specify it with the full Go package path as
a future release of protoc-gen-go will require this be specified.
See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package for more information.
After:
$ protoc vulnerability.proto --go_out=/tmp/
$ echo $?
0