Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception causes in base.py #315

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Conversation

cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Feb 21, 2020

This will make the message displayed between chained exceptions be more accurate.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@cool-RR
Copy link
Contributor Author

cool-RR commented Feb 21, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@afrozenator afrozenator added the ready to pull Added when the PR is ready to be merged. label Mar 19, 2020
@afrozenator
Copy link
Contributor

Thanks @cool-RR - this is a nice addition!

@trax-robot trax-robot merged commit 889afdf into google:master Mar 19, 2020
@cool-RR
Copy link
Contributor Author

cool-RR commented Mar 19, 2020

@afrozenator Would you be interested in the same changes in other parts of the codebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull Added when the PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants