Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T2T input shuffling #151

Merged
merged 2 commits into from
Dec 10, 2019
Merged

Conversation

pzielinski-nyc
Copy link
Contributor

Shuffling flags passed to train_and_eval _dataset method (line 265) were never propagated to tensor2tensor dataset loading, which caused t2t to be non-deterministic (despite train_shuffle_files set to False).

@afrozenator afrozenator added the ready to pull Added when the PR is ready to be merged. label Dec 10, 2019
@afrozenator
Copy link
Contributor

Nice find @pzielinski-nyc, thanks! Will merge in shortly!

trax-robot pushed a commit that referenced this pull request Dec 10, 2019
@trax-robot trax-robot merged commit b3e234b into google:master Dec 10, 2019
@pzielinski-nyc pzielinski-nyc deleted the t2t_input_shuffling branch December 10, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull Added when the PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants