Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PretrainedBERT init #1135

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Conversation

hepaajan
Copy link
Contributor

new_weights was renamed to init_weights_and_state and weights are stored
in self.weights

@google-cla
Copy link

google-cla bot commented Oct 21, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@afrozenator
Copy link
Contributor

Hi @hepaajan -- Can you sign the CLA as instructed by the bot?

@hepaajan
Copy link
Contributor Author

Oh, sorry, This slipped my mind, now it's signed. Let's wait for the bot to pick it up :)

new_weights was renamed to init_weights_and_state and weights are stored
in self.weights
@hepaajan
Copy link
Contributor Author

Rebased and fixed my email (which was accidentally work email)

@afrozenator
Copy link
Contributor

afrozenator commented Nov 17, 2020 via email

@hepaajan
Copy link
Contributor Author

It seems it automatically checked it again. It should ok now as googlebot added a "cla:yes" label

Thanks! You'll still need to reply with @googlebot I signed it! for it to check again.

On Mon, Nov 16, 2020 at 11:38 PM hepaajan @.***> wrote: Rebased and fixed my email (which was accidentally work email) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1135 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIUEFSYIFDT5P4Z7ITIIH3SQISANANCNFSM4SZKG5MQ .
-- We are here on earth to do good for others. What the others are here for, I don't know. Afroz Mohiuddin

@afrozenator
Copy link
Contributor

afrozenator commented Nov 17, 2020 via email

@afrozenator afrozenator added the ready to pull Added when the PR is ready to be merged. label Nov 17, 2020
@copybara-service copybara-service bot merged commit 0a140f8 into google:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull Added when the PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants