-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PretrainedBERT init #1135
Fix PretrainedBERT init #1135
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hi @hepaajan -- Can you sign the CLA as instructed by the bot? |
Oh, sorry, This slipped my mind, now it's signed. Let's wait for the bot to pick it up :) |
new_weights was renamed to init_weights_and_state and weights are stored in self.weights
22d3c25
to
7d301f7
Compare
Rebased and fixed my email (which was accidentally work email) |
Thanks! You'll still need to reply with `@googlebot I signed it!` for it to
check again.
…On Mon, Nov 16, 2020 at 11:38 PM hepaajan ***@***.***> wrote:
Rebased and fixed my email (which was accidentally work email)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1135 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIUEFSYIFDT5P4Z7ITIIH3SQISANANCNFSM4SZKG5MQ>
.
--
We are here on earth to do good for others. What the others are here for, I
don't know.
Afroz Mohiuddin
|
It seems it automatically checked it again. It should ok now as googlebot added a "cla:yes" label
|
Ah, nice! Didn't see that, sorry.
…On Tue, Nov 17, 2020, 8:40 AM hepaajan ***@***.***> wrote:
It seems it automatically checked it again. It should ok now as googlebot
added a "cla:yes" label
Thanks! You'll still need to reply with @googlebot I signed it! for it to
check again.
… <#m_6933270259695040512_>
On Mon, Nov 16, 2020 at 11:38 PM hepaajan *@*.***> wrote: Rebased and
fixed my email (which was accidentally work email) — You are receiving this
because you commented. Reply to this email directly, view it on GitHub <#1135
(comment)
<#1135 (comment)>>, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIUEFSYIFDT5P4Z7ITIIH3SQISANANCNFSM4SZKG5MQ
.
-- We are here on earth to do good for others. What the others are here
for, I don't know. Afroz Mohiuddin
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1135 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIUEFUAZBQN42PB5CBMIYDSQKROTANCNFSM4SZKG5MQ>
.
|
new_weights was renamed to init_weights_and_state and weights are stored
in self.weights