Fix PyTorch 2.13 named overload compatibility#102
Draft
juicyzhou wants to merge 1 commit into
Draft
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
qihqi
reviewed
Jul 15, 2026
| return get_summand(ix_nearest, iy_nearest, iz_nearest, 1) | ||
|
|
||
|
|
||
| _OPTIONAL_NAMED_TENSOR_OVERLOADS = [ |
Collaborator
There was a problem hiding this comment.
no need this hack. Just deleting in decompositions would be good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101.
Summary
Root cause
PyTorch 2.13 removed named tensors and their ATen overloads.
torchax.ampaccessed two removed overloads at module import time, andtorchax.decompositionsreferenced another 20 removed overloads while constructing the default environment. Accessing any missing overload raisesAttributeErrorbefore torchax can be used.The compatibility lookup preserves the existing registrations on older PyTorch versions and skips only unavailable named-tensor overloads on 2.13 and later.
Validation
pytest -q test/test_torch_compat.py test/test_amp.py— 6 passedpytest -q test/test_torch_compat.py test/test_amp.py— 6 passedimport torchaxandtorchax.default_env()succeedruff checkandruff format --checkpass for all changed Python files