-
Notifications
You must be signed in to change notification settings - Fork 231
Upgrade project's build-time dependencies #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Upgrade project's build-time dependencies #35
Conversation
40ff4b6
to
8abbb8e
Compare
@simplexatg hello. Currently, it is not possible or I don't know how to build the project in android studio. If I could build, I would fix everything myself. please fix it. it is a one time work but forever |
@jozuasijsling-ing even this does not work. I Openned this in android studio and it gets errors gradle sink issues, and gives error. I really whished the build issues be resolved, So I can work on it. Talkback is really a good screenreader, But it just should be worked on. |
Hi @amirmahdifard, happy to help but I'll need error details. To start with, please share the error output. Also, what operating system are you using? If you're on an Apple machine with ARM CPU you might be running into this NDK issue: |
Upgraded AGP (Android Gradle Plugin) to 8.4.0. Removed unused aspectjtools plugin declaration.
…checking, relying instead on Gradle wrapper and AGP for detecting and reporting such issues.
8abbb8e
to
24ea5a0
Compare
@jozuasijsling-ing he wants to build under Windows which is not possible without WSL2 or VM. He's constantly spamming in all PRs and issues... |
@jozuasijsling-ing I tryed this pr, because you said this pr makes it possible to build the project on windows with android studio, so I thort that that means we are now able to just build this on windows with out knowing anything about linux wich is apparently not possible, so sorry about that. @PatrykMis i'm sorry about my so much exitements about I thort finally I can build talkback and improve it myself, and also i'm sorry about my really boring life that made me spam issues by my short time comments. Now I understand that this is not possible, and I have already gave up, and my comments will no longer annoy you. Thanks and sorry about that, this was my last comment. |
Let's upgrade tooling so that developers with recent Android Studio versions can build the project out of the box.
AGP 8.4.0 needs at least Gradle 8.6, while Android Studio Jellyfish (current latest stable) ships with Gradle 8.4
making it the same as the library modules
as it is not needed according to
./gradlew checkJetifier
as it is enabled by default
:uiunderstanding
aspectjtools
build.sh
, so that it…