Skip to content

Conversation

jozuasijsling-ing
Copy link

@jozuasijsling-ing jozuasijsling-ing commented May 8, 2024

Let's upgrade tooling so that developers with recent Android Studio versions can build the project out of the box.

  • Upgraded AGP (Android Gradle Plugin) to 8.4.0
  • Embedded Gradle wrapper version 8.7
    AGP 8.4.0 needs at least Gradle 8.6, while Android Studio Jellyfish (current latest stable) ships with Gradle 8.4
  • Changed root module's compileSdk version to 34
    making it the same as the library modules
  • Disabled Jetifier
    as it is not needed according to ./gradlew checkJetifier
  • Removed multiDexEnabled instruction
    as it is enabled by default
  • Removed unused module :uiunderstanding
  • Removed unused plugin declaration for aspectjtools
  • Reworked build.sh , so that it…
    • …works even when started from another directory
    • …uses Gradle wrapper for downloading the Gradle binary
    • …relies on AGP for detecting and reporting missing environment variables

@jozuasijsling-ing jozuasijsling-ing force-pushed the jozuasijsling/upgrade-build-tooling branch 5 times, most recently from 40ff4b6 to 8abbb8e Compare May 8, 2024 20:05
@amirmahdifard
Copy link

@simplexatg hello. Currently, it is not possible or I don't know how to build the project in android studio. If I could build, I would fix everything myself. please fix it. it is a one time work but forever

@amirmahdifard
Copy link

@jozuasijsling-ing even this does not work. I Openned this in android studio and it gets errors gradle sink issues, and gives error. I really whished the build issues be resolved, So I can work on it. Talkback is really a good screenreader, But it just should be worked on.

@jozuasijsling-ing
Copy link
Author

jozuasijsling-ing commented Mar 6, 2025

Hi @amirmahdifard, happy to help but I'll need error details. To start with, please share the error output. Also, what operating system are you using?

If you're on an Apple machine with ARM CPU you might be running into this NDK issue:
https://stackoverflow.com/a/69555276

Upgraded AGP (Android Gradle Plugin) to 8.4.0.
Removed unused aspectjtools plugin declaration.
…checking, relying instead on Gradle wrapper and AGP for detecting and reporting such issues.
@jozuasijsling-ing jozuasijsling-ing force-pushed the jozuasijsling/upgrade-build-tooling branch from 8abbb8e to 24ea5a0 Compare March 6, 2025 12:50
@PatrykMis
Copy link

@jozuasijsling-ing he wants to build under Windows which is not possible without WSL2 or VM. He's constantly spamming in all PRs and issues...

@amirmahdifard
Copy link

@jozuasijsling-ing I tryed this pr, because you said this pr makes it possible to build the project on windows with android studio, so I thort that that means we are now able to just build this on windows with out knowing anything about linux wich is apparently not possible, so sorry about that. @PatrykMis i'm sorry about my so much exitements about I thort finally I can build talkback and improve it myself, and also i'm sorry about my really boring life that made me spam issues by my short time comments. Now I understand that this is not possible, and I have already gave up, and my comments will no longer annoy you. Thanks and sorry about that, this was my last comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants