Split docs/rules/layers/table-c4b-layer-description.csv#225
Split docs/rules/layers/table-c4b-layer-description.csv#225pkatarzynski wants to merge 3 commits intogoogle:mainfrom
Conversation
Signed-off-by: Piotr Katarzynski <pkatarzynski@antmicro.com>
mithro
left a comment
There was a problem hiding this comment.
Looks like we lost a bunch of newlines?
|
I removed the \n strings from the source CSV as they appeared as redundant "n" characters in the RTD table |
|
Doesn't #208 fix that? |
|
The script https://github.com/google/skywater-pdk/blob/master/docs/rules/periphery/periphery-split-csv.py handles periphery rules kept in a separate RST and associated CSV files. The layer rules are defined in a CSV that is explicitly included in the RST. Would it be better to make the peripherly-split-csv.py more general and re-generate the remaining rule tables from CSVs using that script? The other approach (which I followed) assumes cleaning the source CSVs. |
mithro
left a comment
There was a problem hiding this comment.
Could you rework this so the newlines work correctly?
|
Cleaning up the CSV file is fine, we just should clean up the CSV file by making the newlines work correctly? |
|
Friendly ping! |
Signed-off-by: Wojciech Gryncewicz <wgryncewicz@antmicro.com>
Signed-off-by: Wojciech Gryncewicz <wgryncewicz@antmicro.com>
Tweaks the /docs/rules/layers/table-c4b-layer-description.csv table and exports the notes appended to the CSV out of the table.
Fixes #144