Skip to content

Conversation

@mccakit
Copy link

@mccakit mccakit commented Nov 21, 2025

I'm sorry but creating a PR for skia looks very weird, so I'm just submitting my changes to the mirror in hope it someone can actuaally upstream my changes.

This PR adds mingw support to skia, it does this by checking the target triplet, and using either is_msvc or is_mingw, to fix header conflicts with rfc.h, some files have interface keyword replaced with iface

@skia-codereview-bot
Copy link

This PR (HEAD: a82704e) has been imported to Gerrit for code review.

Please visit review.skia.org/1107780 to see it. Please CC yourself to the Gerrit change.

Note:

  • Skia uses only Gerrit for reviews and submitting code (doc).
  • All comments are handled within Gerrit. Any comments on the GitHub PR will be ignored.
  • The PR author can continue to upload commits to the branch used by the PR in order to address feedback from Gerrit.
  • Once the code is ready to be merged, a maintainer will submit the change on Gerrit and skia-codereview-bot will close this PR.
  • Similarly, if a change is abandoned on Gerrit, the corresponding PR will be closed with a note.

@HinTak
Copy link

HinTak commented Nov 21, 2025

You can file your changes at https://issues.skia.org (you just need a Gmail account) for consideration and discussion. You get much better responses than doing pulls here. I believe doing pulls here you end up having to pass review at https://reviews.skia.prg anyway, so you might as well post your suggestions at *.skia.org .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants