Add support for configuring font edging/hinting/subpixel to SkParagraph#198
Add support for configuring font edging/hinting/subpixel to SkParagraph#198xoofx wants to merge 2 commits intogoogle:mainfrom
Conversation
|
This PR (HEAD: 8281f63) has been imported to Gerrit for code review. Please visit review.skia.org/980356 to see it. Please CC yourself to the Gerrit change. Note:
|
xoofx
force-pushed
the
add_sk_paragraph_font_edging_hinting_subpixel
branch
from
8281f63 to
bdee75f
Compare
|
Hi! This is super useful, being able to handle this at paragraph level would be very handy 🙏🏽 |
Hello, This PR is adding support for specifying Font edging / hinting / subpixel to `SkParagraph`/`TextStyle`. Previously, the values were hardcoded to: ```c font.setEdging(SkFont::Edging::kAntiAlias); font.setHinting(SkFontHinting::kSlight); font.setSubpixel(true); ``` This PR allows to configure these properties from `TextStyle` directly. This is an imported pull request from #198 Added the author to the Skia AUTHORS list. GitOrigin-RevId: 274788e Change-Id: I4609700548ef79fec92513161bb0e053b7849091 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/980356 Reviewed-by: Julia Lavrova <jlavrova@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
|
This PR is being closed because review.skia.org/980356 has been merged. |
22 similar comments
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
28 similar comments
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
|
This PR is being closed because review.skia.org/980356 has been merged. |
3 participants
Hello,
This PR is adding support for specifying Font edging / hinting / subpixel to
SkParagraph/TextStyle.Previously, the values were hardcoded to:
This PR allows to configure these properties from
TextStyledirectly.