-
Notifications
You must be signed in to change notification settings - Fork 328
Enhance/4774 - Allow testing tags in non-production environments #5349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rename Tag_Environment_Type_GuardTest class.
…4774-allow-testing-tags.
eugene-manuilov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @hussain-t. Mostly looks good to me. Added a few minor comments. Once they are addressed, we should be good to go.
| if ( ! is_array( $allowed_environments ) ) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fallback to array( 'production' ) if $allowed_environments is not array or is an empty array.
tests/phpunit/integration/Core/Tags/Guards/Tag_Environment_Type_GuardTest.php
Show resolved
Hide resolved
eugene-manuilov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Added one suggestion that I'll apply by myself.
eugene-manuilov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist