Enhancement/#11812 - Implement new designs for the TourTooltip component
#11934
+181
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust close icon size and conditionally render indicators based on feature availability.
…omponent. Adjust tooltip display based on setup flow refresh feature availability.
…ant. Enhance decorators for fetchMock setup to improve story switching functionality.
|
Storybook is ready:
|
|
Size Change: +2.73 kB (+0.12%) Total Size: 2.22 MB ℹ️ View Unchanged
|
|
Build files for fba95fd are ready:
|
nfmohit
requested changes
Dec 27, 2025
Collaborator
nfmohit
left a comment
nfmohit
left a comment
There was a problem hiding this comment.
Thank you for your work on this, @hussain-t.
I've left a number of comments for your consideration. Please let me know if you have any questions or concerns. Thanks!
Comment on lines
+227
to
+234
| .googlesitekit-tooltip-title { | ||
| font-family: $f-primary; | ||
| font-size: $fs-title-lg; | ||
| font-weight: $fw-medium; | ||
| letter-spacing: $ls-xxs; | ||
| line-height: $lh-title-lg; | ||
| margin-bottom: 8px; | ||
| } |
Collaborator
There was a problem hiding this comment.
According to the Figma designs, typography for this should be title-md.
Suggested change
| .googlesitekit-tooltip-title { | |
| font-family: $f-primary; | |
| font-size: $fs-title-lg; | |
| font-weight: $fw-medium; | |
| letter-spacing: $ls-xxs; | |
| line-height: $lh-title-lg; | |
| margin-bottom: 8px; | |
| } | |
| .googlesitekit-tooltip-title { | |
| font-family: $f-primary; | |
| font-size: $fs-title-md; | |
| font-weight: $fw-medium; | |
| letter-spacing: $ls-xxs; | |
| line-height: $lh-title-md; | |
| margin-bottom: 8px; | |
| } |
Comment on lines
+236
to
+242
| .googlesitekit-tooltip-content { | ||
| font-family: $f-primary; | ||
| font-size: $fs-body-md; | ||
| font-weight: $fw-normal; | ||
| letter-spacing: $ls-s; | ||
| line-height: $lh-body-md; | ||
| } |
Collaborator
There was a problem hiding this comment.
- According to the Figma designs, typography for this should be
body-sm. - I don't think it is necessary to specify the font family and weight.
- Letter spacing should be
$ls-xs.
Suggested change
| .googlesitekit-tooltip-content { | |
| font-family: $f-primary; | |
| font-size: $fs-body-md; | |
| font-weight: $fw-normal; | |
| letter-spacing: $ls-s; | |
| line-height: $lh-body-md; | |
| } | |
| .googlesitekit-tooltip-content { | |
| font-size: $fs-body-sm; | |
| letter-spacing: $ls-xs; | |
| line-height: $lh-body-sm; | |
| } |
Comment on lines
+254
to
+265
| .googlesitekit-tooltip-button { | ||
| border-radius: $br-lg; | ||
| line-height: 20px; | ||
|
|
||
| &:focus { | ||
| outline: none; | ||
| } | ||
|
|
||
| &:focus:not(:active) { | ||
| outline: 2px solid $c-interactive-inverse-focus; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Have we considered conditionally removing the text prop from the button component if the feature flag is enabled? I think that would let us reduce some style overrides.
Additionally, can you kindly check if we render the tooltip outside the Site Kit context? If not, I think we can safely wrap the story template with a googlesitekit-plugin class, which will let the tooltip inherit a number of default styles.
Comment on lines
+272
to
+279
| .googlesitekit-tooltip-steps { | ||
| font-family: $f-primary; | ||
| font-size: $fs-label-md; | ||
| font-weight: $fw-medium; | ||
| letter-spacing: $ls-xs; | ||
| line-height: $lh-label-md; | ||
| margin: 0; | ||
| } |
Collaborator
There was a problem hiding this comment.
- According to the Figma designs, this should use a
body-smtypography. - Font weight should be 400.
Suggested change
| .googlesitekit-tooltip-steps { | |
| font-family: $f-primary; | |
| font-size: $fs-label-md; | |
| font-weight: $fw-medium; | |
| letter-spacing: $ls-xs; | |
| line-height: $lh-label-md; | |
| margin: 0; | |
| } | |
| .googlesitekit-tooltip-steps { | |
| font-family: $f-primary; | |
| font-size: $fs-body-sm; | |
| font-weight: $fw-normal; | |
| letter-spacing: $ls-xs; | |
| line-height: $lh-body-sm; | |
| margin: 0; | |
| } |
| .googlesitekit-tooltip-title { | ||
| color: $c-content-on-primary; | ||
|
|
||
| // The tooltip title overrides the default Typography styles. |
Collaborator
There was a problem hiding this comment.
IMO, it'd be wiser to apply styles from the Typography component directly, and only override them like this when the setupFlowRefresh feature flag is not enabled (i.e. .googlesitekit-tour-tooltip:not(.googlesitekit-tour-tooltip--setupFlowRefresh) {}). We'll achieve two benefits from this change:
- The style addition will be very minimal as our new Typography styles will be applied from the component itself.
- Removing the feature flag at launch will be much simpler, where we'll just be able to remove the styles being overridden.
What do you think?
Comment on lines
89
to
97
| @@ -98,7 +114,13 @@ | |||
Collaborator
There was a problem hiding this comment.
According to the Figma designs, the "Back" button should be a tertiary button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
TourTooltipcomponent to reflect the new design. #11812Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist