Skip to content

Force AdSense API messages with links to open in a new window #8204

Open

Description

Bug Description

When AdSense is connected, on the dashboard, AdSense API messages appear. Sometimes there are links included in the message and currently when a user clicks them they do not open up in a new window. I mentioned this to Evan in Slack and he confirmed that these should be opening in a new tab since they use _target=blank but it could be they are implemented as buttons now, in which case that wouldn't work. He asked me to open an issue to investigate & address.

image.png

Steps to reproduce

  1. Connect AdSense but use an account that has messages with links in the account (oi.ie has messages)
  2. Go to the Dashboard and see messages appearing.
  3. Click on one of the links and see it opens in the same window.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Module: AdSenseGoogle AdSense module related issuesType: EnhancementImprovement of an existing feature

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions