Adds an initial commit for mlx port with a Sequence class#5
Open
KEHANG wants to merge 1 commit intogoogle:mainfrom
Open
Adds an initial commit for mlx port with a Sequence class#5KEHANG wants to merge 1 commit intogoogle:mainfrom
KEHANG wants to merge 1 commit intogoogle:mainfrom
Conversation
JulianSlzr
requested changes
Feb 5, 2026
Collaborator
JulianSlzr
left a comment
JulianSlzr
left a comment
There was a problem hiding this comment.
Thanks for starting this! Let's also merge to a mlx branch for now?
Collaborator
There was a problem hiding this comment.
Guess you named this basic_types.py since it doesn't fully cover types.py, but I think it's better to keep the module names (and the *_test.py pattern) between backends consistent as long as we can.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an initial commit for mlx port with a Sequence class