Fix WithContext to exclude string members (#98) - #219
Open
cochinescu wants to merge 1 commit into
Open
Conversation
Every generated schema type is a union that includes `string` (e.g.
`Organization = OrganizationLeaf | ... | string`). `WithContext<T>` was
emitted as `T & { "@context": ... }`, which left a meaningless
`string & { "@context" }` branch in the result — exactly the
"cannot intersect string and object" defect reported in google#98.
WithContext is only ever applied to a top-level object, so strip the
non-object members: emit `Exclude<T, string> & { "@context": ... }`.
This matches the maintainer-suggested fix and the factory's own comment.
Adds a generator baseline regression test asserting the emitted shape,
a consumer-level assertion that `WithContext<Thing>` has no string member,
and regenerates the affected baseline snapshots.
Fixes google#98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every generated schema type is a union that includes
string(e.g.Organization = OrganizationLeaf | ... | string).WithContext<T>was emitted asT & { "@context": ... }, which left a meaninglessstring & { "@context" }branch in the result — exactly the "cannot intersect string and object" defect reported in #98.WithContext is only ever applied to a top-level object, so strip the non-object members: emit
Exclude<T, string> & { "@context": ... }. This matches the maintainer-suggested fix and the factory's own comment.Adds a generator baseline regression test asserting the emitted shape, a consumer-level assertion that
WithContext<Thing>has no string member, and regenerates the affected baseline snapshots.Fixes #98