Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: duplicates bug in SNTMetricSet when using multiple fields #920

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

pmarkowsky
Copy link
Contributor

Fix a bug in SNTMetricSet that was producing duplicates of a metric cell when the metric had multiple fields.

Other Changes

  • This changes the santactl metric command to print metrics with multiple fields as key value pairs e.g. key=value,key2=value2
  • Updates to JSON test files.

@pmarkowsky pmarkowsky added bug metrics Code / work related to Santa observability / monitoring santactl labels Oct 27, 2022
@pmarkowsky pmarkowsky self-assigned this Oct 27, 2022
@pmarkowsky pmarkowsky force-pushed the markowsky/fix-snt-metric-set branch from 364b1bc to a722c40 Compare October 27, 2022 20:24
Source/santactl/Commands/SNTCommandMetrics.m Outdated Show resolved Hide resolved
Source/santactl/Commands/SNTCommandMetrics.m Outdated Show resolved Hide resolved
Source/santactl/Commands/SNTCommandMetrics.m Outdated Show resolved Hide resolved
Source/santactl/Commands/SNTCommandMetrics.m Outdated Show resolved Hide resolved
@pmarkowsky pmarkowsky merged commit 4821ebe into google:main Oct 28, 2022
@pmarkowsky pmarkowsky deleted the markowsky/fix-snt-metric-set branch October 28, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug metrics Code / work related to Santa observability / monitoring santactl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants