Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spool writer #908

Merged
merged 11 commits into from
Oct 21, 2022
Merged

Spool writer #908

merged 11 commits into from
Oct 21, 2022

Conversation

mlw
Copy link
Contributor

@mlw mlw commented Oct 19, 2022

  • Adds a new spool writer to write serialized bytes to the fsspool log batch writer.
  • Adds a new santactl command printlog to dump log file contents.

@mlw mlw added the santad Work related to the Santa Daemon label Oct 19, 2022
pmarkowsky
pmarkowsky suggested changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we can get rid of the sleeps in tests this is good to go.

Source/santactl/Commands/SNTCommandPrintLog.mm Show resolved Hide resolved
Source/santad/Logs/EndpointSecurity/Writers/Spool.mm Show resolved Hide resolved
Source/santad/Logs/EndpointSecurity/Writers/SpoolTest.mm Outdated Show resolved Hide resolved
pmarkowsky
pmarkowsky approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Source/santad/Logs/EndpointSecurity/Writers/Spool.mm Show resolved Hide resolved
@mlw mlw merged commit e7281f1 into google:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russellhancox russellhancox russellhancox left review comments

@pmarkowsky pmarkowsky pmarkowsky approved these changes

@kallsyms kallsyms Awaiting requested review from kallsyms

@tburgin tburgin Awaiting requested review from tburgin

Assignees
No one assigned
Labels
santad Work related to the Santa Daemon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlw @russellhancox @pmarkowsky