Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

santad: Log team ID in execution logs, where available #850

Merged
merged 3 commits into from
Jul 15, 2022
Merged

santad: Log team ID in execution logs, where available #850

merged 3 commits into from
Jul 15, 2022

Conversation

russellhancox
Copy link
Contributor

Fixes #776

@russellhancox russellhancox requested a review from pmarkowsky July 14, 2022 23:18
@russellhancox
Copy link
Contributor Author

I should note that this is re-using the team ID field from the cached decision, which comes from MOLCodesignChecker rather than the one provided directly by ES. The reason for this is that it matches what we're using for decisions and using the ES version would require adding more fields to santa_message_t, which is going to be updated (or removed) in #844; moving over to using the ES-provided team ID will be part of that PR.

@russellhancox russellhancox added this to the 2022.7 Release milestone Jul 14, 2022
@russellhancox russellhancox requested a review from tburgin July 15, 2022 15:54
pmarkowsky
pmarkowsky approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@russellhancox russellhancox merged commit 743c567 into google:main Jul 15, 2022
@russellhancox russellhancox deleted the teamid-logs branch July 15, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tburgin tburgin tburgin approved these changes

@pmarkowsky pmarkowsky pmarkowsky approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2022.7 Release
Development

Successfully merging this pull request may close these issues.

Log Team IDs
3 participants
@russellhancox @pmarkowsky @tburgin