Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

santad: Improve caching of static rules #847

Merged
merged 3 commits into from
Jul 14, 2022

Conversation

russellhancox
Copy link
Contributor

In #846 I forgot that is only a count of the entries so if the config changes but the number of rules remains the same we would never update the cache. This PR moves the processing of the raw config into the KVO handler code so it is not at all in the hot-path. It also does more checking of types in the rule dictionary processing code.

In #846 I forgot that  is only a count of the entries so if the config changes but the number of rules remains the same we would never update the cache. This PR moves the processing of the raw config into the KVO handler code so it is not at all in the hot-path.
tburgin
tburgin previously approved these changes Jul 14, 2022
Source/common/SNTRule.m Outdated Show resolved Hide resolved
@russellhancox russellhancox merged commit 9db00d1 into google:main Jul 14, 2022
@russellhancox russellhancox deleted the mdm-rules-redux branch July 14, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants