Add team ID to synced events #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellhancox
added
enhancement
sync service
|
Thanks for the PR! Would you mind adding an assertion to the event upload test here? santa/Source/santasyncservice/SNTSyncTest.m Line 331 in a67801d |
This is not a great test. The event fixture doesn't have a Team ID, and since it is an event about the `yes` binary, it would be weird to add one.
|
Not too happy with the last commit. How would you like me to proceed? Update the fixture to include a Team ID? I also took the liberty to put the extra test after the cert test, for consistency with the other additions in this PR. |
|
@np5 yes please update the fixture to include a Team ID. |
|
I didn't know really how to proceed, so I simply manually edited the fixture and added a Team ID to the |
russellhancox
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The team ID cannot be extracted from the signing certificate information, when the binary comes from the App Store. With this PR, we are trying to include it in the event information.