This repository has been archived by the owner on Feb 5, 2025. It is now read-only.
Fix: remediate a crash in santametricservice #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows an export timeout to be set via configuration and eases testing.
mlw
approved these changes
Feb 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash in santametricservice by making sure to cancel the
NSURLSessionDataTaskwhen a timeout has been detected.The issue was manifesting as a segfault where the stack variable that was captured inside the block was no longer valid.
Additionally this adds a configuration option
MetricExportTimeoutthat's used to make this simpler to test and also user tunable.