Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync: Allow configuring proxies #708

Merged
merged 5 commits into from
Jan 13, 2022
Merged

Sync: Allow configuring proxies #708

merged 5 commits into from
Jan 13, 2022

Conversation

russellhancox
Copy link
Contributor

Fixes #672

pmarkowsky
pmarkowsky reviewed Jan 11, 2022
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we just need to add update the .md to document the feature.

@russellhancox
Copy link
Contributor Author

Looks good. I think we just need to add update the .md to document the feature.

Good call, done.

@russellhancox russellhancox enabled auto-merge (squash) January 12, 2022 01:32
pmarkowsky
pmarkowsky approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@russellhancox russellhancox merged commit 9c80f79 into google:main Jan 13, 2022
@russellhancox russellhancox deleted the sync-proxy branch January 13, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmarkowsky pmarkowsky pmarkowsky approved these changes

@tburgin tburgin Awaiting requested review from tburgin

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Santa Proxy Support
2 participants
@russellhancox @pmarkowsky