Skip to content
This repository has been archived by the owner on Feb 5, 2025. It is now read-only.

Update hedron_compile_commands #704

Merged
merged 2 commits into from
Dec 30, 2021
Merged

Update hedron_compile_commands #704

merged 2 commits into from
Dec 30, 2021

Conversation

cpsauer
Copy link
Contributor

@cpsauer cpsauer commented Dec 25, 2021

Hey guys, hedron_compile_commands creator here. Smiled (as an ex-Googler) seeing that you'd set it up in #690. Thanks for giving it a try!

Figured I'd PR an update to the latest while I was here--esp since I just fixed an issue someone else was having.
I'd love it if you'd let me know how things go!

Chris

P.S. Couple pieces of unsolicited advice: Renovate is pretty sweet for automating keeping things up to date. And things might work even better with refresh_compile_commands.

@russellhancox
Copy link
Contributor

Thank you Chris for the PR and for the project.

I was planning to look at Renovate early in the new year, for various reasons it might not be simple for us to adopt but I'd like to try. As for things working better with refresh_compile_commands, is that referring to adding a rule in our top-level BUILD file? I initially added that but using the fallback seemed to work equally well but I probably missed something?

@cpsauer
Copy link
Contributor Author

cpsauer commented Dec 29, 2021

Oh great! If it's working equally well, then not a problem :)
[I'm realizing now, belatedly, that the benefit is mostly when you're cross compiling, but here the host and target platform are the same.]

@russellhancox russellhancox merged commit da29b20 into google:main Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants