Use default event detail button text when a custom URL is set (#1161)

google · Aug 23, 2023 · 4fdc1e5 · 4fdc1e5
1 parent 1cdd04f
commit 4fdc1e5
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/Source/gui/SNTBinaryMessageWindowController.m b/Source/gui/SNTBinaryMessageWindowController.m
@@ -84,7 +84,10 @@ - (void)loadWindow {
 
   if (!url) {
     [self.openEventButton removeFromSuperview];
-  } else {
+  } else if (self.customURL.length == 0) {
+    // Set the button text only if a per-rule custom URL is not used. If a
+    // custom URL is used, it is assumed that the `EventDetailText` config value
+    // does not apply and the default text will be used.
     NSString *eventDetailText = [[SNTConfigurator configurator] eventDetailText];
     if (eventDetailText) {
       [self.openEventButton setTitle:eventDetailText];