Use new Apple docs link for global proxy settings constants (#1367)

* Use new Apple docs link for global proxy settings constants * Missed a file... * WIP test workflow change * WIP Fix link * Remove trailing whitespace
google · Jun 18, 2024 · 1472921 · 1472921
1 parent c3d29e3
commit 1472921
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/check-markdown.yml b/.github/workflows/check-markdown.yml
@@ -16,4 +16,5 @@ jobs:
         with:
           fail: true
       - name: "Check for trailing whitespace and newlines"
+        if: '!cancelled()'
         run: "! git grep -EIn $'[ \t]+$' -- ':(exclude)*.patch'"
diff --git a/Source/common/SNTConfigurator.h b/Source/common/SNTConfigurator.h
@@ -403,7 +403,7 @@
 ///  Proxy settings for syncing.
 ///  This dictionary is passed directly to NSURLSession. The allowed keys
 ///  are loosely documented at
-///  https://developer.apple.com/documentation/cfnetwork/global_proxy_settings_constants.
+///  https://developer.apple.com/documentation/cfnetwork/global-proxy-settings-constants.
 ///
 @property(readonly, nonatomic) NSDictionary *syncProxyConfig;
 

diff --git a/docs/deployment/configuration.md b/docs/deployment/configuration.md
@@ -45,7 +45,7 @@ also known as mobileconfig files, which are in an Apple-specific XML format.
 | ModeNotificationLockdown           | String     | The notification text to display when the client goes into Lockdown mode. Defaults to "Switching into Lockdown mode". |
 | SyncBaseURL                        | String     | The base URL of the sync server. |
 | SyncEnableProtoTransfer            | Bool       | If true, sync will happen using binary protos instead of JSON. Defaults to false. |
-| SyncProxyConfiguration             | Dictionary | The proxy configuration to use when syncing. See the [Apple Documentation](https://developer.apple.com/documentation/cfnetwork/global_proxy_settings_constants) for details on the keys that can be used in this dictionary. |
+| SyncProxyConfiguration             | Dictionary | The proxy configuration to use when syncing. See the [Apple Documentation](https://developer.apple.com/documentation/cfnetwork/global-proxy-settings-constants) for details on the keys that can be used in this dictionary. |
 | SyncEnableCleanSyncEventUpload     | Bool       | If true, events will be uploaded to the sync server even if a clean sync is requested. Defaults to false. |
 | ClientAuthCertificateFile          | String     | If set, this contains the location of a PKCS#12 certificate to be used for sync authentication. |
 | ClientAuthCertificatePassword      | String     | Contains the password for the PKCS#12 certificate. |

diff --git a/docs/development/contributing.md b/docs/development/contributing.md
@@ -40,7 +40,7 @@ All submissions related to the use of different identifiers should adhere to the
 | Identifier | Notes | Example |
 | -------- | ------- | ------- |
 | SHA-256  | lowercase |  `801d1dd8bc78984c126a269aca053642d16eef4389dfdc8df575af929fdcf279` |
-| CDHash | lowercase | `2d1cff4b1080058e7e5913e5a3398bcd0199b6a4` | 
+| CDHash | lowercase | `2d1cff4b1080058e7e5913e5a3398bcd0199b6a4` |
 | TeamID | uppercase | `43AQ936H96` |
 | Signing ID | case insensitive | `EQHXZ8M8AV:com.google.Chrome` |