Skip to content

Expand Python Bindings to include S2RegionTermIndexer - #160

Merged
jmr merged 5 commits into
google:masterfrom
rcoup:py-expand
Dec 14, 2020
Merged

Expand Python Bindings to include S2RegionTermIndexer#160
jmr merged 5 commits into
google:masterfrom
rcoup:py-expand

Conversation

@rcoup

@rcoup rcoup commented Dec 1, 2020

Copy link
Copy Markdown
Contributor
  • Make it possible to follow the Indexing for Search and Querying for Search sections in the Quickstart guide from Python.
  • Primarily expand the Python bindings to include S2RegionTermIndexer
  • And related changes for testing
  • Port the term_index.cc example to Python as well for good measure.
  • Add some repr() methods

Fixes #84

@google-cla

google-cla Bot commented Dec 1, 2020

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@rcoup

rcoup commented Dec 1, 2020

Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@jmr jmr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Comment thread doc/examples/term_index.py Outdated
Comment thread doc/examples/term_index.py Outdated
Comment thread doc/examples/term_index.py Outdated
Comment thread doc/examples/term_index.py Outdated
Comment thread src/python/pywraps2_test.py Outdated
Comment thread src/python/s2_common.i
Comment thread src/python/s2_common.i
Comment thread src/python/s2_common.i Outdated
Comment thread src/python/s2_common.i
Comment thread src/python/s2_common.i
@rcoup
rcoup force-pushed the py-expand branch 3 times, most recently from a84e0ce to 31d1d4f Compare December 3, 2020 16:03
@rcoup

rcoup commented Dec 3, 2020

Copy link
Copy Markdown
Contributor Author

@jmr ready for another look

@google-cla

google-cla Bot commented Dec 9, 2020

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@rcoup

rcoup commented Dec 9, 2020

Copy link
Copy Markdown
Contributor Author

@googlebot I fixed it

@rcoup

rcoup commented Dec 10, 2020

Copy link
Copy Markdown
Contributor Author

@jmr I think this is good to go now.

Comment thread src/python/s2_common.i
Comment thread src/python/s2_common.i Outdated
@rcoup

rcoup commented Dec 14, 2020

Copy link
Copy Markdown
Contributor Author

Done, will do a new PR for repr

@jmr
jmr merged commit c59d0ca into google:master Dec 14, 2020
jmr pushed a commit to gregcoombe/s2geometry that referenced this pull request Jan 6, 2021
* Python: Implement S2Earth class

* Python: implement some key S2Testing methods

* Python: implement S2RegionTermIndexer and tests

* Python: Port the `term_index` C++ example to Python.

* Update authors/contributors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python bindings do not include S2RegionTermIndexer

2 participants