Expand Python Bindings to include S2RegionTermIndexer - #160
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
a84e0ce to
31d1d4f
Compare
|
@jmr ready for another look |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@googlebot I fixed it |
|
@jmr I think this is good to go now. |
|
Done, will do a new PR for repr |
* Python: Implement S2Earth class * Python: implement some key S2Testing methods * Python: implement S2RegionTermIndexer and tests * Python: Port the `term_index` C++ example to Python. * Update authors/contributors
S2RegionTermIndexerterm_index.ccexample to Python as well for good measure.repr()methodsFixes #84