ICU upluralrules #130
Merged
ICU upluralrules #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the plural rule types and functions, like `uplrules_open` or `UPluralType` available for use. Since these changes are as a rule large but mechanical, let's offload them to this separate commit. Issue google#127
This should have been done when 0.3.0 was released. It would be nice to automate the process completely. Issue google#127
Plural rules determines what gets printed when one needs to format "1 file" or "10 files" for human consumption. Each language may have very own rules about what number is considered singular, what is considered plural. Languages have different rules about the numbers subject to the rule, and even about the number of plurals that are used. Closes google#127
v0.3.1 will not be released for some time. See issue google#127
|
@kpozin I stacked multiple commits here, let me know if this makes the review unwieldy and I'll do differently in the future. |
kpozin
approved these changes
Jun 17, 2020
Hides the docs by default, since we don't want the unsafe function to be widely used. Fixes a typo in the doc formulation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the support for locale-sensitive plural rules
Plural rules determines what gets printed when one needs to format "1 file"
or "10 files" for human consumption. Each language may have very own rules
about what number is considered singular, what is considered plural.
Languages have different rules about the numbers subject to the rule, and
even about the number of plurals that are used.
Closes #127