fixup: handles the review comments

google · Mar 2, 2021 · fc64773 · fc64773
1 parent 8632748
commit fc64773
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/rust_icu_ecma402/src/datetimeformat.rs b/rust_icu_ecma402/src/datetimeformat.rs
@@ -33,6 +33,7 @@ pub(crate) mod internal {
     use rust_icu_ustring as ustring;
     use std::convert::TryFrom;
 
+    // TODO: implement this conversion completely.
     pub fn opt_to_pattern(_opts: DateTimeFormatOptions) -> Result<ustring::UChar, common::Error> {
         ustring::UChar::try_from("YYYY")
     }

diff --git a/rust_icu_uloc/src/lib.rs b/rust_icu_uloc/src/lib.rs
@@ -940,4 +940,14 @@ mod tests {
         assert_eq!(ULoc::for_language_tag("en-t-it-u-tz-usnyc-nu-arabic-x-foo")?, loc);
         Ok(())
     }
+
+    #[test]
+    fn test_uloc_mut_add_unicode_extension() -> Result<(), Error> {
+        let loc = ULoc::for_language_tag("en-t-it-x-foo")?;
+        let mut loc_mut = ULocMut::from(loc);
+        loc_mut.set_unicode_keyvalue("tz", "usnyc");
+        let loc = ULoc::from(loc_mut);
+        assert_eq!(ULoc::for_language_tag("en-t-it-u-tz-usnyc-x-foo")?, loc);
+        Ok(())
+    }
 }