Exclude tests returning std::optional<T> from TestReturnsOrderingOrSearchGuide#37
Open
sfreilich wants to merge 1 commit intogoogle:masterfrom
Open
Exclude tests returning std::optional<T> from TestReturnsOrderingOrSearchGuide#37sfreilich wants to merge 1 commit intogoogle:masterfrom
std::optional<T> from TestReturnsOrderingOrSearchGuide#37sfreilich wants to merge 1 commit intogoogle:masterfrom
Conversation
…SearchGuide Since those are matched by an overload enabled on TestReturnsOptionalOrderingOrSearchGuide, matching both results in `error: call to 'BinarySearch' is ambiguous`. Though I suspect both shouldn't be matched anyways, since I'm only seeing this under a build using `clang-cl` on Windows, not clang on Linux (both using C++20). Also replace `decltype(std::declval<Test>()(std::declval<Pos>()))` with the much clearer `std::invoke_result_t<Test, Pos>`, since the code already requires C++17.
copybara-service bot
pushed a commit
to google/ink-stroke-modeler
that referenced
this pull request
Jun 18, 2025
Regenerate fuzztest.bazelrc for that version. Update CMake build to use the same versions. Exclude fuzztest target from the Windows clang-cl build, the underlying build has problems with clang-cl specifically, and I was only able to fix some of them (after patching google/riegeli#37, it still wouldn't build due to some issue linking HighwayHash). PiperOrigin-RevId: 770272280
copybara-service bot
pushed a commit
to google/ink-stroke-modeler
that referenced
this pull request
Jun 18, 2025
Regenerate fuzztest.bazelrc for that version. Update CMake build to use the same versions. Exclude fuzztest target from the Windows clang-cl build, the underlying build has problems with clang-cl specifically, and I was only able to fix some of them (after patching google/riegeli#37, it still wouldn't build due to some issue linking HighwayHash). PiperOrigin-RevId: 770272280
copybara-service bot
pushed a commit
to google/ink-stroke-modeler
that referenced
this pull request
Jun 18, 2025
Regenerate fuzztest.bazelrc for that version. Update CMake build to use the same versions. Exclude fuzztest target from the Windows clang-cl build, the underlying build has problems with clang-cl specifically, and I was only able to fix some of them (after patching google/riegeli#37, it still wouldn't build due to some issue linking HighwayHash). PiperOrigin-RevId: 770272280
copybara-service bot
pushed a commit
to google/ink-stroke-modeler
that referenced
this pull request
Jun 23, 2025
Regenerate fuzztest.bazelrc for that version. Update CMake build to use the same versions. Exclude fuzztest target from the Windows clang-cl build, the underlying build has problems with clang-cl specifically, and I was only able to fix some of them (after patching google/riegeli#37, it still wouldn't build due to some issue linking HighwayHash). PiperOrigin-RevId: 770272280
copybara-service bot
pushed a commit
to google/ink-stroke-modeler
that referenced
this pull request
Jun 23, 2025
Regenerate fuzztest.bazelrc for that version. Update CMake build to use the same versions. Exclude fuzztest target from the Windows clang-cl build, the underlying build has problems with clang-cl specifically, and I was only able to fix some of them (after patching google/riegeli#37, it still wouldn't build due to some issue linking HighwayHash). PiperOrigin-RevId: 770272280
copybara-service bot
pushed a commit
to google/ink-stroke-modeler
that referenced
this pull request
Jun 23, 2025
Regenerate fuzztest.bazelrc for that version. Update CMake build to use the same versions. Exclude fuzztest target from the Windows clang-cl build, the underlying build has problems with clang-cl specifically, and I was only able to fix some of them (after patching google/riegeli#37, it still wouldn't build due to some issue linking HighwayHash). PiperOrigin-RevId: 770272280
copybara-service bot
pushed a commit
to google/ink-stroke-modeler
that referenced
this pull request
Jun 23, 2025
Regenerate fuzztest.bazelrc for that version. Update CMake build to use the same versions. Exclude fuzztest target from the Windows clang-cl build, the underlying build has problems with clang-cl specifically, and I was only able to fix some of them (after patching google/riegeli#37, it still wouldn't build due to some issue linking HighwayHash). PiperOrigin-RevId: 770272280
copybara-service bot
pushed a commit
to google/ink-stroke-modeler
that referenced
this pull request
Jun 23, 2025
Regenerate fuzztest.bazelrc for that version. Update CMake build to use the same versions. Exclude fuzztest target from the Windows clang-cl build, the underlying build has problems with clang-cl specifically, and I was only able to fix some of them (after patching google/riegeli#37, it still wouldn't build due to some issue linking HighwayHash). PiperOrigin-RevId: 770272280
copybara-service bot
pushed a commit
to google/ink-stroke-modeler
that referenced
this pull request
Jun 23, 2025
Regenerate fuzztest.bazelrc for that version. Update CMake build to use the same versions. Exclude fuzztest target from the Windows clang-cl build, the underlying build has problems with clang-cl specifically, and I was only able to fix some of them (after patching google/riegeli#37, it still wouldn't build due to some issue linking HighwayHash). PiperOrigin-RevId: 770272280
copybara-service bot
pushed a commit
to google/ink-stroke-modeler
that referenced
this pull request
Jun 23, 2025
Regenerate fuzztest.bazelrc for that version. Update CMake build to use the same versions. Exclude fuzztest target from the Windows clang-cl build, the underlying build has problems with clang-cl specifically, and I was only able to fix some of them (after patching google/riegeli#37, it still wouldn't build due to some issue linking HighwayHash). PiperOrigin-RevId: 770272280
copybara-service bot
pushed a commit
to google/ink-stroke-modeler
that referenced
this pull request
Jun 23, 2025
Regenerate fuzztest.bazelrc for that version. Update CMake build to use the same versions. Exclude fuzztest target from the Windows clang-cl build, the underlying build has problems with clang-cl specifically, and I was only able to fix some of them (after patching google/riegeli#37, it still wouldn't build due to some issue linking HighwayHash). PiperOrigin-RevId: 770272280
copybara-service bot
pushed a commit
to google/ink-stroke-modeler
that referenced
this pull request
Jun 23, 2025
Regenerate fuzztest.bazelrc for that version. Update CMake build to use the same versions. Exclude fuzztest target from the Windows clang-cl build, the underlying build has problems with clang-cl specifically, and I was only able to fix some of them (after patching google/riegeli#37, it still wouldn't build due to some issue linking HighwayHash). PiperOrigin-RevId: 774892150
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since those are matched by an overload enabled on TestReturnsOptionalOrderingOrSearchGuide, matching both results in
error: call to 'BinarySearch' is ambiguous. Though I suspect both shouldn't be matched anyways, since I'm only seeing this under a build usingclang-clon Windows, not clang on Linux (both using C++20).Also replace
decltype(std::declval<Test>()(std::declval<Pos>()))with the much clearerstd::invoke_result_t<Test, Pos>, since the code already requires C++17.