Skip to content
This repository was archived by the owner on Jan 10, 2023. It is now read-only.

Conversation

@tgalal
Copy link
Contributor

@tgalal tgalal commented May 30, 2015

For example:

python adb_debug.py pull src dest

dest was getting dropped and command always failed. Not sure if it's the correct way to fix it, but it worked for me.

@fahhem
Copy link
Contributor

fahhem commented May 31, 2015

Ah, this is because Pull has dest_file as a default arg to allow just getting the file's data directly.

I'd prefer something that changed line 140 to:

  if num_args == 1 and method_name != 'pull':

@tgalal
Copy link
Contributor Author

tgalal commented May 31, 2015

I think the idea is that cli introspects methods and generates usage out of it, and therefore shouldn't make assumptions about specific methods/ method names. There should be a better way to fix it while maintaining its intended design purpose.

@fahhem
Copy link
Contributor

fahhem commented Jun 1, 2015

Yeah, on second thought, just remove the line entirely.

@fahhem fahhem closed this in 438f86b Oct 27, 2015
maruel added a commit to maruel/python-adb that referenced this pull request Jun 17, 2016
CPU scaling fallback to scaling_[min|max]_freq, not cpuinfo_....
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants