Make type caster of std::unique_ptr accept return_value_policy::automatic_reference
#30058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangxf123456
force-pushed
the
unique_ptr_automatic_reference
branch
from
500d7af
to
ed7fece
Compare
|
Merge to smart_holder branch instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pybind11 always override
return_value_policy::automaticandreturn_value_policy::automatic_referencewithreturn_value_policy::moveforstd::unique_ptr: https://github.com/google/pywrapcc/blob/8bcd157442a1e02bb0bc06515e938bbb5f487564/include/pybind11/cast.h#L1277, soreturn_value_policy::automaticandreturn_value_policy::automatic_referencedoes not make any difference forstd::unique_ptr. We should make the type caster accept both.