shorten the deprecation messages for clone() and copyWith() #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
|
What's the goal with this? The issue and old depreciation message have the same information, but now it's more difficult to see as you have to click on a link and load a web page. |
|
The generated code is currently pretty hard to read (and the code serves as API - both for regular protos, and for generated grpc client libraries - so readability matters). I think switching from three lines for the deprecation annotation + description to one line helps here. |
osa1
approved these changes
May 19, 2025
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
May 19, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. protobuf (https://github.com/dart-lang/protobuf/compare/b7753f6..deda288): deda288 2025-05-19 Devon Carew address a merge issue with the protoc_plugin changelog (google/protobuf.dart#1002) 5ed4611 2025-05-19 Devon Carew shorten the deprecation messages for clone() and copyWith() (google/protobuf.dart#999) 4960b92 2025-05-19 Ömer Sinan Ağacan Switch to pub workspace (google/protobuf.dart#1001) test (https://github.com/dart-lang/test/compare/b9c59ea..5ffcb36): 5ffcb36f 2025-05-19 Danny Tuppeny Fix an issue with failed assertions using setUpAll/tearDownAll (dart-lang/test#2499) Change-Id: Idc43e2f2fd9dc38b80917b25b45bb954076dc1c9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/429480 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done as two commits for easier review.