-
Notifications
You must be signed in to change notification settings - Fork 189
move generated test code from out/ to test/gen/ #1009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,4 +3,7 @@ | |
| pubspec.lock | ||
|
|
||
| # Other generated files | ||
| test/gen/ | ||
|
|
||
| # Legacy (can be deleted locally) | ||
| out/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,119 @@ | ||
| // Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file | ||
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| import 'package:test/test.dart'; | ||
|
|
||
| import 'gen/google/protobuf/unittest.pb.dart'; | ||
| import 'gen/google/protobuf/unittest_import.pb.dart'; | ||
| import 'gen/map_field.pb.dart'; | ||
| import 'test_util.dart'; | ||
|
|
||
| void main() { | ||
| group('map_field', () { | ||
| test('Constructor map arguments accept key-value iterators', () { | ||
| final msg = TestMap( | ||
| stringToInt32Field: [ | ||
| MapEntry('a', 1), | ||
| MapEntry('b', 2), | ||
| MapEntry('a', 3) | ||
| ], | ||
| int32ToStringField: {1: 'hi'}.entries, | ||
| ); | ||
| expect(msg.stringToInt32Field['a'], 3); | ||
| expect(msg.stringToInt32Field['b'], 2); | ||
| expect(msg.int32ToStringField[1], 'hi'); | ||
| }); | ||
| }); | ||
|
|
||
| group('generated_message', () { | ||
| test('Named arguments in constructors', () { | ||
| final value = TestAllTypes( | ||
| optionalInt32: 101, | ||
| optionalInt64: make64(102), | ||
| optionalUint32: 103, | ||
| optionalUint64: make64(104), | ||
| optionalSint32: 105, | ||
| optionalSint64: make64(106), | ||
| optionalFixed32: 107, | ||
| optionalFixed64: make64(108), | ||
| optionalSfixed32: 109, | ||
| optionalSfixed64: make64(110), | ||
| optionalFloat: 111.0, | ||
| optionalDouble: 112.0, | ||
| optionalBool: true, | ||
| optionalString: '115', | ||
| optionalBytes: '116'.codeUnits, | ||
| optionalGroup: TestAllTypes_OptionalGroup(a: 117), | ||
| optionalNestedMessage: TestAllTypes_NestedMessage(bb: 118), | ||
| optionalForeignMessage: ForeignMessage(c: 119), | ||
| optionalImportMessage: ImportMessage(d: 120), | ||
| optionalNestedEnum: TestAllTypes_NestedEnum.BAZ, | ||
| optionalForeignEnum: ForeignEnum.FOREIGN_BAZ, | ||
| optionalImportEnum: ImportEnum.IMPORT_BAZ, | ||
| optionalStringPiece: '124', | ||
| optionalCord: '125', | ||
| repeatedInt32: [201, 301], | ||
| repeatedInt64: [make64(202), make64(302)], | ||
| repeatedUint32: [203, 303], | ||
| repeatedUint64: [make64(204), make64(304)], | ||
| repeatedSint32: [205, 305], | ||
| repeatedSint64: [make64(206), make64(306)], | ||
| repeatedFixed32: [207, 307], | ||
| repeatedFixed64: [make64(208), make64(308)], | ||
| repeatedSfixed32: [209, 309], | ||
| repeatedSfixed64: [make64(210), make64(310)], | ||
| repeatedFloat: [211.0, 311.0], | ||
| repeatedDouble: [212.0, 312.0], | ||
| repeatedBool: [true, false], | ||
| repeatedString: ['215', '315'], | ||
| repeatedBytes: ['216'.codeUnits, '316'.codeUnits], | ||
| repeatedGroup: [ | ||
| TestAllTypes_RepeatedGroup(a: 217), | ||
| TestAllTypes_RepeatedGroup(a: 317) | ||
| ], | ||
| repeatedNestedMessage: [ | ||
| TestAllTypes_NestedMessage(bb: 218), | ||
| TestAllTypes_NestedMessage(bb: 318) | ||
| ], | ||
| repeatedForeignMessage: [ | ||
| ForeignMessage(c: 219), | ||
| ForeignMessage(c: 319) | ||
| ], | ||
| repeatedImportMessage: [ImportMessage(d: 220), ImportMessage(d: 320)], | ||
| repeatedNestedEnum: [ | ||
| TestAllTypes_NestedEnum.BAR, | ||
| TestAllTypes_NestedEnum.BAZ | ||
| ], | ||
| repeatedForeignEnum: [ForeignEnum.FOREIGN_BAR, ForeignEnum.FOREIGN_BAZ], | ||
| repeatedImportEnum: [ImportEnum.IMPORT_BAR, ImportEnum.IMPORT_BAZ], | ||
| repeatedStringPiece: ['224', '324'], | ||
| repeatedCord: ['225', '325'], | ||
| defaultInt32: 401, | ||
| defaultInt64: make64(402), | ||
| defaultUint32: 403, | ||
| defaultUint64: make64(404), | ||
| defaultSint32: 405, | ||
| defaultSint64: make64(406), | ||
| defaultFixed32: 407, | ||
| defaultFixed64: make64(408), | ||
| defaultSfixed32: 409, | ||
| defaultSfixed64: make64(410), | ||
| defaultFloat: 411.0, | ||
| defaultDouble: 412.0, | ||
| defaultBool: false, | ||
| defaultString: '415', | ||
| defaultBytes: '416'.codeUnits, | ||
| defaultNestedEnum: TestAllTypes_NestedEnum.FOO, | ||
| defaultForeignEnum: ForeignEnum.FOREIGN_FOO, | ||
| defaultImportEnum: ImportEnum.IMPORT_FOO, | ||
| defaultStringPiece: '424', | ||
| defaultCord: '425', | ||
| ); | ||
|
|
||
| // Convert the message with constructor arguments to the message without | ||
| // constructor arguments, to be able to reuse `assertAllFieldsSet`. | ||
| assertAllFieldsSet(TestAllTypes.fromBuffer(value.writeToBuffer())); | ||
| }); | ||
| }); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we no longer
disable_constror_args? Is it not necessary?Maybe we could rely on g3 tests for this. In g3
disable_constructor_argsis the default as it causes binary size bloat.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're generating two versions of the test protos output for this one option - I'm just trying to dial things back a bit (we don't do this for other options). The disable_constructor_args option is tested in protoc_plugin/test/file_generator_test.dart and a bit in message_generator_test.dart.
Given the history in the changelog It sounds like having ctor args is the default externally, and not having them is the default internally.