[FR] package-wide include directory #71

Activity

1. DanAlbert

   added

   enhancementNew feature or requestNew feature or request

   requires schema changeAn issue that requires a schema change to fix.An issue that requires a schema change to fix.

   on Feb 25, 2020
2. alexcohn commented on Feb 26, 2020

   

   alexcohn

   on Feb 26, 2020

   More actions

   This is not critical; e.g. in ffmpeg, all consumers essentially link libavutil. Therefore, we can put the headers under libavutil module.

   There is another duplication problem with ffmpeg: currently, I have separate include directories for each ABI. It is not clear whether I can use one major include directory and only store ABI-dependent headers (very few) under prefab/modules/libavutil/libs/anroid.x86 etc. ?
3. DanAlbert commented on Feb 26, 2020

   

   DanAlbert

   on Feb 26, 2020

   Last edited by DanAlbert

   ContributorAuthor

   More actions

   prefab/api/src/main/kotlin/com/google/prefab/api/PrebuiltLibrary.kt

   Lines 35 to 43 in 5b576fb

   	/**
   	* The path to the headers on disk.
   	*
   	* This is the path to the platform-specific include path if it exists.
   	* Otherwise this is the path to the module's include path.
   	*/
   	val includePath: Path =
   	directory.resolve("include").takeIf { it.toFile().exists() }
   	?: module.includePath

   Platform specific headers override module level headers rather than exposing two include directories. Going to fork off two more bugs for that: a schema change for supporting that, and a doc bug to clarify that behavior somewhere other than buried in the source :)
4. DanAlbert commented on Feb 26, 2020

   

   DanAlbert

   on Feb 26, 2020

   ContributorAuthor

   More actions

   Filed #75 and #76
5. DanAlbert

   added this to the 2.0 milestone on Jun 4, 2020