Display hovered box details immediately.

[ghemawat]

Display the details (name + samples) of the currently hovered box above the flame graph. If no box is currently being hovered over, we display the total samples in the flame graph.

Fixes #836.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.34%. Comparing base (0ed6a68) to head (4fd3b29).
Report is 38 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #897      +/-   ##
==========================================
+ Coverage   66.86%   67.34%   +0.48%     
==========================================
  Files          44       44              
  Lines        9824     9825       +1     
==========================================
+ Hits         6569     6617      +48     
+ Misses       2794     2761      -33     
+ Partials      461      447      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[aalexand]

I wonder if it would be useful if this new left details box would show the name of the pivot function when in pivot mode and not hovering any other node. This would give an easy way to copy to clipboard the name of a function of interest - pivot, move mouse to details, select, copy.

[ghemawat]

I wonder if it would be useful if this new left details box would show the name of the pivot function when in pivot mode and not hovering any other node

In general, the pivot can be regexp so it can match many functions (useful for example to pivot on std::string to find all string usage). And the pivot is already fairly clear since we have an extra timing display just above the pivot(s). E.g., in the following we have pivoted on "swap":

[aalexand]

I wonder if it would be useful if this new left details box would show the name of the pivot function when in pivot mode and not hovering any other node

In general, the pivot can be regexp so it can match many functions (useful for example to pivot on std::string to find all string usage). And the pivot is already fairly clear since we have an extra timing display just above the pivot(s). E.g., in the following we have pivoted on "swap":

I was mostly thinking about the general ability to easily copy the function name for a given flame graph node. It's a separate feature perhaps, doesn't have to be discussed now or even prioritized until people ask for it.

[hzeller]

Thanks Sanjay!