Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/driver: fix spelling in help text #2

Merged
merged 1 commit into from
Feb 19, 2016
Merged

internal/driver: fix spelling in help text #2

merged 1 commit into from
Feb 19, 2016

Conversation

dgryski
Copy link
Contributor

@dgryski dgryski commented Feb 17, 2016

No description provided.

@rauls5382
Copy link
Contributor

Thanks for the patch.

In order to accept your patch, I need you to sign the Google CLA, at https://cla.developers.google.com/about/google-individual

@dgryski
Copy link
Contributor Author

dgryski commented Feb 19, 2016

I've already signed it for my patches in Go: https://github.com/golang/go/blob/master/AUTHORS#L154

@rauls5382
Copy link
Contributor

The tool we use to check for CLAs can't find your github account.

It could be because the email address used to sign the CLA is not associated to your github account.
Can you add it if it isn't there? It doesn't have to be the primary email on the account.

Thanks

@dgryski
Copy link
Contributor Author

dgryski commented Feb 19, 2016

It already is :/ Both dgryski@gmail.com and damian@gryski.com are in my profile.

@dgryski
Copy link
Contributor Author

dgryski commented Feb 19, 2016

I have just set my Gmail to be the primary public email address for my account.

@rauls5382
Copy link
Contributor

Thanks. Sorry for the churn. I checked and it is OK as is. I'll merge the pull request.

Also, if you want, you can login to cla.developers.google.com and add your github account to your existing CLA. But it's not strictly necessary.

rauls5382 added a commit that referenced this pull request Feb 19, 2016
internal/driver: fix spelling in help text
@rauls5382 rauls5382 merged commit ff34f17 into google:master Feb 19, 2016
lannadorai pushed a commit to lannadorai/pprof that referenced this pull request Mar 1, 2018
Remove profile_wrappers and unused functions
kalyanac added a commit that referenced this pull request May 6, 2020
Recognize an executable without symbols
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants