-
Notifications
You must be signed in to change notification settings - Fork 605
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Introduce first test for browser-side behavior.
Added a test that uses chromedp to drive web page interactions and check the resulting display. Also disable "GOPATH" mode tests with Go tip since "go get" support for that was deleted from Go on Aug 16 by golang/go@de4d503 Caveat: just adding a single test initially (it checks sorting of the "Top" view table). Other tests will be added later. Caveat: coverage of browser Javascript is not gathered, so we won't be able to rely on coverage to measure quality/changes in Javascript testing.
- Loading branch information
Showing
4 changed files
with
153 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,31 @@ | ||
| github.com/chromedp/cdproto v0.0.0-20230802225258-3cf4e6d46a89 h1:aPflPkRFkVwbW6dmcVqfgwp1i+UWGFH6VgR1Jim5Ygc= | ||
| github.com/chromedp/cdproto v0.0.0-20230802225258-3cf4e6d46a89/go.mod h1:GKljq0VrfU4D5yc+2qA6OVr8pmO/MBbPEWqWQ/oqGEs= | ||
| github.com/chromedp/chromedp v0.9.2 h1:dKtNz4kApb06KuSXoTQIyUC2TrA0fhGDwNZf3bcgfKw= | ||
| github.com/chromedp/chromedp v0.9.2/go.mod h1:LkSXJKONWTCHAfQasKFUZI+mxqS4tZqhmtGzzhLsnLs= | ||
| github.com/chromedp/sysutil v1.0.0 h1:+ZxhTpfpZlmchB58ih/LBHX52ky7w2VhQVKQMucy3Ic= | ||
| github.com/chromedp/sysutil v1.0.0/go.mod h1:kgWmDdq8fTzXYcKIBqIYvRRTnYb9aNS9moAV0xufSww= | ||
| github.com/chzyer/logex v1.2.1 h1:XHDu3E6q+gdHgsdTPH6ImJMIp436vR6MPtH8gP05QzM= | ||
| github.com/chzyer/logex v1.2.1/go.mod h1:JLbx6lG2kDbNRFnfkgvh4eRJRPX1QCoOIWomwysCBrQ= | ||
| github.com/chzyer/readline v1.5.1 h1:upd/6fQk4src78LMRzh5vItIt361/o4uq553V8B5sGI= | ||
| github.com/chzyer/readline v1.5.1/go.mod h1:Eh+b79XXUwfKfcPLepksvw2tcLE/Ct21YObkaSkeBlk= | ||
| github.com/chzyer/test v1.0.0 h1:p3BQDXSxOhOG0P9z6/hGnII4LGiEPOYBhs8asl/fC04= | ||
| github.com/chzyer/test v1.0.0/go.mod h1:2JlltgoNkt4TW/z9V/IzDdFaMTM2JPIi26O1pF38GC8= | ||
| github.com/gobwas/httphead v0.1.0 h1:exrUm0f4YX0L7EBwZHuCF4GDp8aJfVeBrlLQrs6NqWU= | ||
| github.com/gobwas/httphead v0.1.0/go.mod h1:O/RXo79gxV8G+RqlR/otEwx4Q36zl9rqC5u12GKvMCM= | ||
| github.com/gobwas/pool v0.2.1 h1:xfeeEhW7pwmX8nuLVlqbzVc7udMDrwetjEv+TZIz1og= | ||
| github.com/gobwas/pool v0.2.1/go.mod h1:q8bcK0KcYlCgd9e7WYLm9LpyS+YeLd8JVDW6WezmKEw= | ||
| github.com/gobwas/ws v1.2.1 h1:F2aeBZrm2NDsc7vbovKrWSogd4wvfAxg0FQ89/iqOTk= | ||
| github.com/gobwas/ws v1.2.1/go.mod h1:hRKAFb8wOxFROYNsT1bqfWnhX+b5MFeJM9r2ZSwg/KY= | ||
| github.com/ianlancetaylor/demangle v0.0.0-20230524184225-eabc099b10ab h1:BA4a7pe6ZTd9F8kXETBoijjFJ/ntaa//1wiH9BZu4zU= | ||
| github.com/ianlancetaylor/demangle v0.0.0-20230524184225-eabc099b10ab/go.mod h1:gx7rwoVhcfuVKG5uya9Hs3Sxj7EIvldVofAWIUtGouw= | ||
| github.com/josharian/intern v1.0.0 h1:vlS4z54oSdjm0bgjRigI+G1HpF+tI+9rE5LLzOg8HmY= | ||
| github.com/josharian/intern v1.0.0/go.mod h1:5DoeVV0s6jJacbCEi61lwdGj/aVlrQvzHFFd8Hwg//Y= | ||
| github.com/ledongthuc/pdf v0.0.0-20220302134840-0c2507a12d80 h1:6Yzfa6GP0rIo/kULo2bwGEkFvCePZ3qHDDTC3/J9Swo= | ||
| github.com/ledongthuc/pdf v0.0.0-20220302134840-0c2507a12d80/go.mod h1:imJHygn/1yfhB7XSJJKlFZKl/J+dCPAknuiaGOshXAs= | ||
| github.com/mailru/easyjson v0.7.7 h1:UGYAvKxe3sBsEDzO8ZeWOSlIQfWFlxbzLZe7hwFURr0= | ||
| github.com/mailru/easyjson v0.7.7/go.mod h1:xzfreul335JAWq5oZzymOObrkdz5UnU4kGfJJLY9Nlc= | ||
| github.com/orisano/pixelmatch v0.0.0-20220722002657-fb0b55479cde h1:x0TT0RDC7UhAVbbWWBzr41ElhJx5tXPWkIHA2HWPRuw= | ||
| github.com/orisano/pixelmatch v0.0.0-20220722002657-fb0b55479cde/go.mod h1:nZgzbfBr3hhjoZnS66nKrHmduYNpc34ny7RK4z5/HM0= | ||
| golang.org/x/sys v0.0.0-20220310020820-b874c991c1a5/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= | ||
| golang.org/x/sys v0.1.0 h1:kunALQeHf1/185U1i0GOB/fy1IPRDDpuoOOqRReG57U= | ||
| golang.org/x/sys v0.1.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= | ||
| golang.org/x/sys v0.6.0 h1:MVltZSvRTcU2ljQOhs94SXPftV6DCNnZViHeQps87pQ= | ||
| golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| // Copyright 2023 Google Inc. All Rights Reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package driver | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "os/exec" | ||
| "regexp" | ||
| "strings" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/chromedp/chromedp" | ||
| ) | ||
|
|
||
| func skipUnlessHaveChrome(t *testing.T) { | ||
| if _, err := exec.LookPath("google-chrome"); err == nil { | ||
| return | ||
| } | ||
| if _, err := exec.LookPath("chrome"); err == nil { | ||
| return | ||
| } | ||
| t.Skip("chrome not available") | ||
| } | ||
|
|
||
| func TestTopTable(t *testing.T) { | ||
| skipUnlessHaveChrome(t) | ||
|
|
||
| prof := makeFakeProfile() | ||
| server := makeTestServer(t, prof) | ||
| ctx, cancel := context.WithTimeout(context.Background(), time.Second*30) | ||
| defer cancel() | ||
| ctx, cancel = chromedp.NewContext(ctx) | ||
| defer cancel() | ||
|
|
||
| err := chromedp.Run(ctx, | ||
| chromedp.Navigate(server.URL+"/top"), | ||
| chromedp.WaitVisible(`#toptable`, chromedp.ByID), | ||
|
|
||
| // Check that fake profile entries show up in the right order. | ||
| matchRegexp(t, "#node0", `200ms.*F2`), | ||
| matchInOrder(t, "#toptable", "F2", "F3", "F1"), | ||
|
|
||
| // Check sorting by cumulative count. | ||
| chromedp.Click(`#cumhdr1`, chromedp.ByID), | ||
| matchInOrder(t, "#toptable", "F1", "F2", "F3"), | ||
| ) | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| } | ||
|
|
||
| // matchRegexp is a chromedp.Action that fetches the text of the first | ||
| // node that matched query and checks that the text matches regexp re. | ||
| func matchRegexp(t *testing.T, query, re string) chromedp.ActionFunc { | ||
| return func(ctx context.Context) error { | ||
| var value string | ||
| err := chromedp.Text(query, &value, chromedp.ByQuery).Do(ctx) | ||
| if err != nil { | ||
| return fmt.Errorf("text %s: %v", query, err) | ||
| } | ||
| t.Logf("text %s:\n%s", query, value) | ||
| m, err := regexp.MatchString(re, value) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if !m { | ||
| return fmt.Errorf("%s: did not find %q in\n%s", query, re, value) | ||
| } | ||
| return nil | ||
| } | ||
| } | ||
|
|
||
| // matchInOrder is a chromedp.Action that fetches the text of the first | ||
| // node that matched query and checks that the supplied sequence of | ||
| // strings occur in order in the text. | ||
| func matchInOrder(t *testing.T, query string, sequence ...string) chromedp.ActionFunc { | ||
| return func(ctx context.Context) error { | ||
| var value string | ||
| err := chromedp.Text(query, &value, chromedp.ByQuery).Do(ctx) | ||
| if err != nil { | ||
| return fmt.Errorf("text %s: %v", query, err) | ||
| } | ||
| t.Logf("text %s:\n%s", query, value) | ||
| remaining := value | ||
| for _, s := range sequence { | ||
| pos := strings.Index(remaining, s) | ||
| if pos < 0 { | ||
| return fmt.Errorf("%s: did not find %q in expected order %v in\n%s", query, s, sequence, value) | ||
| } | ||
| remaining = remaining[pos+len(s):] | ||
| } | ||
| return nil | ||
| } | ||
| } |