Repository navigation
ui: Handle null navigator.keyboard - #7186
Merged
LalitMaganti merged 1 commit intoAug 24, 2026
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
safayat-google
approved these changes
Aug 24, 2026
LalitMaganti
enabled auto-merge (squash)
August 24, 2026 10:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In some browsers, the
keyboardproperty exists onnavigatorbut its value isnull.The existing property-presence check succeeds and then calls
getLayoutMap()onnull, crashing the Perfetto home page:Observed with Perfetto UI v58.2 on Chrome 150 on macOS.
Fix
Declare
navigator.keyboardas nullable and check its value before callinggetLayoutMap().Unsupported environments now throw the existing
NotSupportedError, allowing the UI to use its fallback keyboard layout.I solved it with declare global because I saw they've been used in other parts, could be fixed with cast but ugly, or runtime guard which's verbose..
Additionally getLayoutMap() genuinely returns a Promise according to the Keyboard Map specification, this is the reason I changed it.