Merge "Fix compilation with recent GCC" into main

google · Dec 27, 2023 · 5948e5c · 5948e5c
2 parents 63ad166 + 473092c
commit 5948e5c
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 8 deletions.
diff --git a/include/perfetto/base/compiler.h b/include/perfetto/base/compiler.h
@@ -143,11 +143,7 @@ extern "C" void __asan_unpoison_memory_region(void const volatile*, size_t);
 #endif
 
 // Macro for telling -Wimplicit-fallthrough that a fallthrough is intentional.
-#if defined(__clang__)
-#define PERFETTO_FALLTHROUGH [[clang::fallthrough]]
-#else
-#define PERFETTO_FALLTHROUGH
-#endif
+#define PERFETTO_FALLTHROUGH [[fallthrough]]
 
 namespace perfetto {
 namespace base {

diff --git a/include/perfetto/ext/base/http/sha1.h b/include/perfetto/ext/base/http/sha1.h
@@ -20,6 +20,8 @@
 #include <stddef.h>
 
 #include <array>
+#include <cstddef>
+#include <cstdint>
 #include <string>
 
 namespace perfetto {

diff --git a/include/perfetto/profiling/pprof_builder.h b/include/perfetto/profiling/pprof_builder.h
@@ -17,6 +17,7 @@
 #ifndef INCLUDE_PERFETTO_PROFILING_PPROF_BUILDER_H_
 #define INCLUDE_PERFETTO_PROFILING_PPROF_BUILDER_H_
 
+#include <cstdint>
 #include <string>
 #include <vector>
 

diff --git a/src/base/http/sha1.cc b/src/base/http/sha1.cc
@@ -16,7 +16,6 @@
 #include "perfetto/ext/base/http/sha1.h"
 
 #include <stddef.h>
-#include <stdint.h>
 #include <string.h>
 
 // From chrome_elf/sha1/sha1.cc.

diff --git a/src/base/http/sha1_unittest.cc b/src/base/http/sha1_unittest.cc
@@ -16,6 +16,7 @@
 
 #include "perfetto/ext/base/http/sha1.h"
 
+#include <cstdint>
 #include <string>
 
 #include "perfetto/ext/base/string_view.h"

diff --git a/src/profiling/symbolizer/symbolizer.h b/src/profiling/symbolizer/symbolizer.h
@@ -17,7 +17,7 @@
 #ifndef SRC_PROFILING_SYMBOLIZER_SYMBOLIZER_H_
 #define SRC_PROFILING_SYMBOLIZER_SYMBOLIZER_H_
 
-#include <map>
+#include <cstdint>
 #include <string>
 #include <vector>
 

diff --git a/src/trace_processor/perfetto_sql/intrinsics/operators/span_join_operator.cc b/src/trace_processor/perfetto_sql/intrinsics/operators/span_join_operator.cc
@@ -23,6 +23,7 @@
 #include <set>
 #include <utility>
 
+#include "perfetto/base/compiler.h"
 #include "perfetto/base/logging.h"
 #include "perfetto/base/status.h"
 #include "perfetto/ext/base/string_splitter.h"
@@ -578,7 +579,7 @@ base::Status SpanJoinOperatorTable::Cursor::Column(sqlite3_context* context,
         sqlite3_result_int64(context, static_cast<sqlite3_int64>(partition));
         break;
       }
-      [[clang::fallthrough]];
+      PERFETTO_FALLTHROUGH;
     }
     default: {
       size_t index = static_cast<size_t>(N);

diff --git a/src/traceconv/trace_to_profile.h b/src/traceconv/trace_to_profile.h
@@ -17,6 +17,7 @@
 #ifndef SRC_TRACECONV_TRACE_TO_PROFILE_H_
 #define SRC_TRACECONV_TRACE_TO_PROFILE_H_
 
+#include <cstdint>
 #include <iostream>
 #include <vector>