Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MockHTTPServer for tests #888

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

michaelkedar
Copy link
Member

Factored out the httptest.Server / handler into one struct for easier reuse in tests.

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 70.45455% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 63.10%. Comparing base (f97e5d1) to head (2ff1267).

Files Patch % Lines
internal/testutility/mock_http.go 70.45% 9 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #888      +/-   ##
==========================================
+ Coverage   63.09%   63.10%   +0.01%     
==========================================
  Files         144      145       +1     
  Lines       11824    11868      +44     
==========================================
+ Hits         7460     7489      +29     
- Misses       3893     3904      +11     
- Partials      471      475       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cuixq cuixq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@michaelkedar michaelkedar merged commit 1c01916 into google:main Mar 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants