Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace stereoscope with using go-containerregistry directly #836

Merged
merged 27 commits into from
Mar 6, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
1f06426
PoC of image scanning complete
another-rex Feb 23, 2024
b634879
fix lints
another-rex Feb 27, 2024
1bca578
Efficiently load image
another-rex Feb 28, 2024
89bb36a
remove-profile
another-rex Mar 4, 2024
d1260b7
Add additional comments
another-rex Mar 4, 2024
da8fa15
test
another-rex Mar 4, 2024
9beeea3
Merge remote-tracking branch 'upstream/main' into image-branch
another-rex Mar 4, 2024
2716149
Fix test, prevent decompression bomb
another-rex Mar 4, 2024
212d0a0
Update snapshot and address PR comments
another-rex Mar 4, 2024
62a5e4b
Fix windows test
another-rex Mar 4, 2024
6a29430
Fix zip slip
another-rex Mar 4, 2024
a642f96
Fix trim prefix
another-rex Mar 4, 2024
455d7f4
Fix error logging
another-rex Mar 4, 2024
cee2693
Fix wrong error logging
another-rex Mar 4, 2024
607e262
Add additional close calls
another-rex Mar 5, 2024
c8a956d
Merge remote-tracking branch 'upstream/main' into push-xnmmrmklymzv
another-rex Mar 5, 2024
fd8d8e7
Everything world writable
another-rex Mar 5, 2024
a87a223
clean file paths
another-rex Mar 5, 2024
478f263
Revert mode change
another-rex Mar 5, 2024
2152af7
Refactor to check if extractor exists before opening
another-rex Mar 5, 2024
9370f6e
Always close file even on error, and save permission in filenode rath…
another-rex Mar 5, 2024
faa6aa7
Minor refactoring into separate files, add some more comments, fix pe…
another-rex Mar 5, 2024
224879a
Fix errors
another-rex Mar 6, 2024
2bec30f
Merge branch 'main' into push-xnmmrmklymzv
another-rex Mar 6, 2024
48acfdd
Hide flag
another-rex Mar 6, 2024
9fc27a9
Merge branch 'main' into push-xnmmrmklymzv
another-rex Mar 6, 2024
24c1a97
Fix lints
another-rex Mar 6, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix errors
  • Loading branch information
another-rex committed Mar 6, 2024
commit 224879a8958026b411430f564c4ed63236c7fa75
2 changes: 1 addition & 1 deletion cmd/osv-scanner/__snapshots__/main_test.snap
Original file line number Diff line number Diff line change
Expand Up @@ -1719,7 +1719,7 @@ Scanning image ./fixtures/oci-image/no-file-here.tar
---

[TestRun_OCIImage/Invalid_path - 2]
failed to open image ./fixtures/oci-image/no-file-here.tar: open ./fixtures/oci-image/no-file-here.tar: no such file or directory
failed to load image ./fixtures/oci-image/no-file-here.tar: open ./fixtures/oci-image/no-file-here.tar: no such file or directory

---

Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/google/osv-scanner

go 1.21.5
go 1.21.8

require (
deps.dev/api/v3alpha v0.0.0-20240223021916-3ec708cc3f2e
Expand Down
1 change: 1 addition & 0 deletions internal/image/scan.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
func ScanImage(r reporter.Reporter, imagePath string) (ScanResults, error) {
img, err := loadImage(imagePath)
if err != nil {
img.Cleanup()
return ScanResults{}, fmt.Errorf("failed to load image %s: %w", imagePath, err)
}

Expand Down