Skip to content

Conversation

@another-rex
Copy link
Collaborator

When using the -L flag, we directly call the extractor and construct the scanInput in osv-scanner.

This had a bug where we are not calling ToSlash on windows paths. This fixes this, which also fixes #2152

@another-rex another-rex requested a review from cuixq September 1, 2025 01:46
@cuixq
Copy link
Contributor

cuixq commented Sep 1, 2025

it seems the snapshot action is failing from a few days ago https://github.com/google/osv-scanner/actions/workflows/snapshots.yml (I was wondering why the snapshot diff was not caught by the action)

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2025

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.62%. Comparing base (8efa873) to head (8ef2acc).
⚠️ Report is 68 commits behind head on main.

Files with missing lines Patch % Lines
...nguage/java/pomxmlenhanceable/pomxmlenhanceable.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2214      +/-   ##
==========================================
- Coverage   67.62%   67.62%   -0.01%     
==========================================
  Files         170      170              
  Lines       16326    16336      +10     
==========================================
+ Hits        11041    11047       +6     
- Misses       4605     4609       +4     
  Partials      680      680              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@another-rex another-rex merged commit 18100e2 into google:main Sep 1, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression in requirements.txt since 2.1.0

3 participants