Skip to content

Conversation

@G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Aug 28, 2025

Resolves #1958
Resolves #2178

@G-Rath G-Rath force-pushed the plugins/adjust-flags branch from e9972d4 to 3e4f26f Compare August 28, 2025 20:06
@G-Rath G-Rath force-pushed the plugins/adjust-flags branch from 3e4f26f to 1b5718a Compare September 2, 2025 19:47
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.40%. Comparing base (18100e2) to head (1b5718a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2210      +/-   ##
==========================================
- Coverage   67.62%   67.40%   -0.23%     
==========================================
  Files         170      170              
  Lines       16336    16394      +58     
==========================================
+ Hits        11047    11050       +3     
- Misses       4609     4664      +55     
  Partials      680      680              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR changes the --plugins flag behavior to be additive by default (adding to default plugins) and introduces a new --no-default-plugins flag for excluding defaults when users want to run only specific plugins.

  • Changed plugin resolution logic to append enabled plugins to defaults instead of replacing them
  • Added PluginsNoDefaults field and --experimental-no-default-plugins flag
  • Updated tests to separate behavior testing between default-inclusive and default-exclusive scenarios

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/osvscanner/scan.go Modified plugin resolution logic to append enabled plugins to defaults
pkg/osvscanner/osvscanner.go Added PluginsNoDefaults boolean field to ExperimentalScannerActions struct
docs/migrating-from-scalibr.md Updated documentation to explain new additive behavior and no-default-plugins flag
docs/manual-plugin-selection.md Updated plugin selection documentation with new flag descriptions
cmd/osv-scanner/scan/source/command_test.go Split tests into separate functions for with/without defaults scenarios
cmd/osv-scanner/scan/source/snapshots/command_test.snap Updated test snapshots for new test organization
cmd/osv-scanner/scan/image/command_test.go Split image tests into with/without defaults scenarios
cmd/osv-scanner/scan/image/snapshots/command_test.snap Updated image test snapshots
cmd/osv-scanner/internal/helper/getters.go Added PluginsNoDefaults field extraction from command flags
cmd/osv-scanner/internal/helper/flags.go Added --experimental-no-default-plugins flag definition

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@another-rex another-rex merged commit 0d4f529 into google:main Sep 3, 2025
16 checks passed
@another-rex another-rex deleted the plugins/adjust-flags branch September 3, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make it clearer that the --experimental-plugins flag disables existing plugins Create documentation for (experimental) custom extractors

3 participants