chore: enable redundant-test-main-exit rule for revive linter
#1868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
G-Rath
force-pushed
the
linting/enable-rule
branch
2 times, most recently
from
f179c98 to
bf11bb1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1868 +/- ##
=======================================
Coverage 65.28% 65.28%
=======================================
Files 164 164
Lines 15868 15868
=======================================
Hits 10359 10359
Misses 4845 4845
Partials 664 664 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
G-Rath
force-pushed
the
linting/enable-rule
branch
from
bf11bb1 to
871a044
Compare
hogo6002
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've already addressed the violations of this in #1772, but could not enable the rule at the time as it was mistakenly omitted from the schema used by the action to valid the linter config - now though golangci/golangci-lint#5692 has been released and we've upgraded, that is no longer an issue 🎉