Skip to content

ci: cache test images for reuse across runs #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Mar 27, 2025

While it only tends to take 2-3 minutes, they completely block our three test jobs and in theory it should be very straightforward to cache our test images as (again, in theory) they should be very stable.

Right now I'm just redownloading the tars and skipping the build entirely, though we could also possibly try re-importing them so that we always do a build but they're available as cached layers, which might be a better middleground

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.04%. Comparing base (ac13b3b) to head (449faea).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1757      +/-   ##
==========================================
+ Coverage   64.49%   65.04%   +0.54%     
==========================================
  Files         157      163       +6     
  Lines       15839    15950     +111     
==========================================
+ Hits        10216    10374     +158     
+ Misses       4950     4897      -53     
- Partials      673      679       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@G-Rath G-Rath force-pushed the ci/docker-import branch from f73523b to bbc5b79 Compare March 27, 2025 21:01
@G-Rath G-Rath force-pushed the ci/docker-import branch from bbc5b79 to 6fd8938 Compare March 27, 2025 21:26
@G-Rath G-Rath changed the title ci: try downloading existing image artifacts ci: cache test images for reuse across runs Mar 27, 2025
@G-Rath
Copy link
Collaborator Author

G-Rath commented Mar 27, 2025

@another-rex what do you think about this? It's actually technically not working on this pull request as even though its reporting it's pushed up the cache, it never finds it when doing the restore, but I think that's because this is coming from a fork - I'm curious to see what happens if we just land it

@G-Rath G-Rath closed this May 21, 2025
@G-Rath G-Rath deleted the ci/docker-import branch May 21, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants