feat(updater): use upgrade config for Maven version updater #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuixq
commented
Feb 18, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1636 +/- ##
==========================================
- Coverage 68.77% 68.74% -0.03%
==========================================
Files 200 200
Lines 18998 19147 +149
==========================================
+ Hits 13066 13163 +97
- Misses 5235 5280 +45
- Partials 697 704 +7 ☔ View full report in Codecov by Sentry. |
cuixq
changed the title
michaelkedar
approved these changes
Feb 19, 2025
another-rex
pushed a commit
to another-rex/osv-scanner
that referenced
this pull request
Feb 20, 2025
) This PR aligns the flags of `update`, especially the `upgrade-config` with `fix` subcommand. To be able to parse the upgrade config, this PR moves the parsing function to `upgrade` package. The next step is to make [`comparisonFunctionWithWorkarounds`](https://github.com/google/osv-scanner/blob/e0206dedd17080021b768526f2a6fde635497c25/internal/remediation/override.go#L271) reusable and used in Maven updater as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns the flags of
update, especially theupgrade-configwithfixsubcommand.To be able to parse the upgrade config, this PR moves the parsing function to
upgradepackage.The next step is to make
comparisonFunctionWithWorkaroundsreusable and used in Maven updater as well.