Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace experimental libraries with their std versions #1620

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Feb 13, 2025

These became stable in Go v1.21, so we can stop using the x/exp versions

(this will be enforced by the expotostd linter which is being introduced in the next version of golanglint-ci)

@cuixq
Copy link
Contributor

cuixq commented Feb 14, 2025

@G-Rath I think some tests break due to this change - can you help to fix?

@G-Rath G-Rath force-pushed the lint/replace-exp-libs branch 3 times, most recently from 6e32eac to 4f6cc2c Compare February 18, 2025 01:04
@G-Rath G-Rath force-pushed the lint/replace-exp-libs branch from 4f6cc2c to 07924ad Compare February 18, 2025 01:06
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.75%. Comparing base (e2eb458) to head (22a42de).

Files with missing lines Patch % Lines
cmd/osv-scanner/fix/state-relock-result.go 0.00% 2 Missing ⚠️
scripts/generate_mock_resolution_universe/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1620   +/-   ##
=======================================
  Coverage   68.74%   68.75%           
=======================================
  Files         200      200           
  Lines       19147    19150    +3     
=======================================
+ Hits        13163    13166    +3     
  Misses       5280     5280           
  Partials      704      704           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants