test: rewrite models to use snapshots and tables
#1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1382 +/- ##
==========================================
- Coverage 68.96% 68.94% -0.02%
==========================================
Files 185 185
Lines 17934 17934
==========================================
- Hits 12368 12365 -3
- Misses 4903 4904 +1
- Partials 663 665 +2 ☔ View full report in Codecov by Sentry. |
G-Rath
force-pushed
the
test/use-snaps
branch
2 times, most recently
from
886eaa6 to
9f6d21b
Compare
G-Rath
force-pushed
the
test/use-snaps
branch
from
9f6d21b to
7dfaef3
Compare
another-rex
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier to maintain since we won't need to edit raw JSON - I wouldn't say this is strictly better as some of the tests were small enough that I'd argue the initial overhead of using snapshots makes it less of a win, but ultimately these don't change often so I think it's still better to be consistent with the rest of the codebase
(I've also got a fix or two coming up in this section which'll be made easier by this)