Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set CharsetReader and Entity when reading pom.xml #1325

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

cuixq
Copy link
Contributor

@cuixq cuixq commented Oct 14, 2024

#1321

If non UTF-8 encoding is declared in pom.xml, we need to set CharsetReader to avoid the error.

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.49%. Comparing base (f492e39) to head (0d7258d).

Files with missing lines Patch % Lines
internal/resolution/manifest/maven.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1325      +/-   ##
==========================================
- Coverage   68.49%   68.49%   -0.01%     
==========================================
  Files         177      177              
  Lines       17155    17157       +2     
==========================================
+ Hits        11750    11751       +1     
- Misses       4766     4767       +1     
  Partials      639      639              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cuixq cuixq marked this pull request as ready for review October 14, 2024 00:48
@cuixq cuixq requested review from michaelkedar, another-rex and oliverchang and removed request for michaelkedar October 14, 2024 00:48
@cuixq cuixq merged commit d3b75df into google:main Oct 14, 2024
13 checks passed
@cuixq cuixq deleted the fix branch October 14, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants