-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: address a number of typos #1307
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1307 +/- ##
==========================================
+ Coverage 68.46% 68.48% +0.01%
==========================================
Files 177 177
Lines 17155 17155
==========================================
+ Hits 11745 11748 +3
+ Misses 4771 4769 -2
+ Partials 639 638 -1 ☔ View full report in Codecov by Sentry. |
@G-Rath can you fix the lint issue so I can merge this PR? |
@cuixq the lint failure is a very weird fluke - it doesn't happen locally and I didn't change anything related to that file; hopefully it'll pass on this rerun (I was waiting for something else to be landed to have a reason to rebase, since I don't have permission to trigger job re-runs) |
@cuixq looks like this is just a general failure on |
yes I also noticed that - maybe this is an issue of the linter itself |
@cuixq CI is green now so technically this is good to merge - I couldn't actually find an answer to why linting was failing but I'm hoping it's a very rare fluke; I suspect it could be caching related. |
@G-Rath thank you! I am also thinking to upgrade the linter... |
ha yah I saw your PR - I was thinking of doing the exact same thing, but thankfully saw your PR first 😄 |
I found these while working on other stuff