Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address a number of typos #1307

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix: address a number of typos #1307

merged 1 commit into from
Oct 10, 2024

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Oct 8, 2024

I found these while working on other stuff

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.48%. Comparing base (43f9526) to head (685dcc5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1307      +/-   ##
==========================================
+ Coverage   68.46%   68.48%   +0.01%     
==========================================
  Files         177      177              
  Lines       17155    17155              
==========================================
+ Hits        11745    11748       +3     
+ Misses       4771     4769       -2     
+ Partials      639      638       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/osv-scanner/fix/main.go Outdated Show resolved Hide resolved
internal/thirdparty/xml/read.go Outdated Show resolved Hide resolved
internal/thirdparty/xml/typeinfo.go Outdated Show resolved Hide resolved
@cuixq
Copy link
Contributor

cuixq commented Oct 9, 2024

@G-Rath can you fix the lint issue so I can merge this PR?

@G-Rath
Copy link
Collaborator Author

G-Rath commented Oct 9, 2024

@cuixq the lint failure is a very weird fluke - it doesn't happen locally and I didn't change anything related to that file; hopefully it'll pass on this rerun

(I was waiting for something else to be landed to have a reason to rebase, since I don't have permission to trigger job re-runs)

@G-Rath
Copy link
Collaborator Author

G-Rath commented Oct 9, 2024

@cuixq looks like this is just a general failure on main - I can look into why that's happening shortly, but in the meantime you should be fine to merge this:

image

@cuixq
Copy link
Contributor

cuixq commented Oct 9, 2024

yes I also noticed that - maybe this is an issue of the linter itself

@G-Rath G-Rath marked this pull request as draft October 10, 2024 00:13
@G-Rath G-Rath marked this pull request as ready for review October 10, 2024 00:26
@G-Rath
Copy link
Collaborator Author

G-Rath commented Oct 10, 2024

@cuixq CI is green now so technically this is good to merge - I couldn't actually find an answer to why linting was failing but I'm hoping it's a very rare fluke; I suspect it could be caching related.

@cuixq
Copy link
Contributor

cuixq commented Oct 10, 2024

@G-Rath thank you! I am also thinking to upgrade the linter...

@cuixq cuixq merged commit ca8c00a into google:main Oct 10, 2024
22 of 23 checks passed
@cuixq cuixq deleted the fix-typo branch October 10, 2024 00:28
@G-Rath
Copy link
Collaborator Author

G-Rath commented Oct 10, 2024

ha yah I saw your PR - I was thinking of doing the exact same thing, but thankfully saw your PR first 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants