Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github.com/spdx/gordf dependency to fix 32 bit support #104

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Update github.com/spdx/gordf dependency to fix 32 bit support #104

merged 2 commits into from
Jan 4, 2023

Conversation

kpcyrd
Copy link
Contributor

@kpcyrd kpcyrd commented Dec 30, 2022

This updates the gordf dependency so osv-scanner can be built for 32 bit targets. Related issues:

before

% GOARCH=386 go build ./cmd/osv-scanner/
# github.com/spdx/gordf/rdfloader/xmlreader
../../../go/pkg/mod/github.com/spdx/gordf@v0.0.0-20201111095634-7098f93598fb/rdfloader/xmlreader/xmlreader.go:213:27: WHITESPACE (untyped int constant 4294977024) overflows int
%

after

% GOARCH=386 go build ./cmd/osv-scanner/
%

@inferno-chromium
Copy link
Contributor

/gcbrun

inferno-chromium
inferno-chromium reviewed Dec 30, 2022
View reviewed changes
go.sum Outdated
@@ -25,6 +25,8 @@ github.com/russross/blackfriday/v2 v2.1.0 h1:JIOH55/0cWyOuilr9/qlrm0BSXldqnqwMsf
github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
github.com/spdx/gordf v0.0.0-20201111095634-7098f93598fb h1:bLo8hvc8XFm9J47r690TUKBzcjSWdJDxmjXJZ+/f92U=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these 2 lines with older gordf reference still required ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, running go mod tidy removed one of them but I don't know why the other one is still there. Manually deleting it doesn't work, running go mod tidy is adding it again. Updating all dependencies also doesn't get rid of it:

% go get -u ./...; go mod tidy; grep rdf go.sum 
github.com/spdx/gordf v0.0.0-20201111095634-7098f93598fb/go.mod h1:uKWaldnbMnjsSAXRurWqqrdyZen1R7kxl8TkmWk2OyM=
github.com/spdx/gordf v0.0.0-20221230105357-b735bd5aac89 h1:dArkMwZ7Mf2JiU8OfdmqIv8QaHT4oyifLIe1UhsF1SY=
github.com/spdx/gordf v0.0.0-20221230105357-b735bd5aac89/go.mod h1:uKWaldnbMnjsSAXRurWqqrdyZen1R7kxl8TkmWk2OyM=

@oliverchang
Copy link
Collaborator

/gcbrun

@oliverchang oliverchang enabled auto-merge (squash) January 4, 2023 04:04
@oliverchang
Copy link
Collaborator

/gcbrun

@oliverchang oliverchang merged commit 9dffff8 into google:main Jan 4, 2023
@tuananh
Copy link
Contributor

tuananh commented Jan 4, 2023 •
edited
Loading

can you cut a release so that alpinelinux can package this?

https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/42405

@kpcyrd kpcyrd deleted the 32bit-support branch January 4, 2023 10:21
@oliverchang
Copy link
Collaborator

can you cut a release so that alpinelinux can package this?

https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/42405

We were planning to cut a release next week, or were you looking for something sooner?

@oliverchang oliverchang mentioned this pull request Jan 5, 2023
Closed
@tuananh
Copy link
Contributor

tuananh commented Jan 5, 2023

Thats fine. Thanks

julieqiu pushed a commit to julieqiu/osv-scanner that referenced this pull request May 2, 2023
@kpcyrd @julieqiu
Update github.com/spdx/gordf dependency to fix 32 bit support (google…
320f7e7 
…#104)
julieqiu pushed a commit to julieqiu/osv-scanner that referenced this pull request May 2, 2023
@kpcyrd @julieqiu
Update github.com/spdx/gordf dependency to fix 32 bit support (google…
c667950 
…#104)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inferno-chromium inferno-chromium inferno-chromium left review comments

@oliverchang oliverchang oliverchang approved these changes

@another-rex another-rex Awaiting requested review from another-rex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kpcyrd @inferno-chromium @oliverchang @tuananh